Skip to content

Constrain hero carousel height and stretch to full width on story share portal #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maebeale merged 6 commits into from
Feb 10, 2026
Merged

Constrain hero carousel height and stretch to full width on story share portal #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0708069
Initial plan
Copilot Feb 10, 2026
e7b53e3
Limit hero image height to prevent vertical growth
Copilot Feb 10, 2026
f0d49ca
Allow extra classes to be sent in
maebeale Feb 10, 2026
8ea2118
Don't hard-code the size
maebeale Feb 10, 2026
858e3b9
Stretch hero image to full width horizontally
Copilot Feb 10, 2026
a371a3e
Hard-code nav item colors
maebeale Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions app/views/assets/_display_image.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<% display_open_pdf_link ||= false %>
<% idx ||= 0 %>
<% item_type ||= "PrimaryAsset" %>
<% extra_image_classes ||= "" %>

<% width ||= "32" %>
<% height ||= width %>
Expand Down Expand Up @@ -48,20 +49,20 @@
sizes = {
hero: {
wrapper: "mb-8",
image: "w-full rounded-lg shadow-sm border border-gray-200",
image: "hero-size w-full rounded-lg shadow-sm border border-gray-200 #{extra_image_classes}",
preview: [1200, 1200]
},

gallery: {
wrapper: "flex grow",
image: "#{width_class} #{height_class} object-cover rounded border border-gray-300
shadow-sm hover:opacity-90 transition-opacity",
image: "gallery-size #{width_class} #{height_class} object-cover rounded border border-gray-300
shadow-sm hover:opacity-90 transition-opacity #{extra_image_classes}",
preview: [300, 300]
},

index: {
wrapper: "#{width_class} #{height_class} shrink-0 overflow-hidden rounded border border-gray-300",
image: "w-full h-full object-cover"
wrapper: "index-size #{width_class} #{height_class} shrink-0 overflow-hidden rounded border border-gray-300",
image: "w-full h-full object-cover #{extra_image_classes}"
}
}.fetch(variant)

Expand Down
8 changes: 4 additions & 4 deletions app/views/shared/_share_portal_navbar.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@
<!-- Row 2: Focus Area Navigation -->
<div class="nav-row">
<div class="hidden lg:flex items-center justify-center py-3 space-x-6">
<%= link_to "Home", share_portal_stories_path, class: "font-telefon text-gray-800 hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Home", share_portal_stories_path, class: "font-telefon text-[#5B2C8A] hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Domestic Violence", share_portal_stories_path(focus: "domestic_violence"), class: "font-telefon text-red-700 hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Self-Care & Personal Growth", share_portal_stories_path(focus: "self_care"), class: "font-telefon text-gray-600 hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Self-Care & Personal Growth", share_portal_stories_path(focus: "self_care"), class: "font-telefon text-[#1F6F8B] hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Social Justice", share_portal_stories_path(focus: "social_justice"), class: "font-telefon text-green-700 hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Facilitator Spotlights", share_portal_stories_path(focus: "facilitator_spotlights"), class: "font-telefon text-purple-700 hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Additional Focus Areas", "#", class: "font-telefon text-orange-600 hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Facilitator Spotlights", share_portal_stories_path(focus: "facilitator_spotlights"), class: "font-telefon text-[#8B004B] hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
<%= link_to "Additional Focus Areas", "#", class: "font-telefon text-[#F28C00] hover:bg-gray-100 px-3 py-1 rounded text-sm font-medium transition-all" %>
</div>
</div>

Expand Down
3 changes: 2 additions & 1 deletion app/views/stories/share_portal.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@
<div class="max-w-6xl mx-auto px-4 sm:px-6 lg:px-8">
<div class="relative rounded-lg overflow-hidden shadow-lg" id="hero-carousel">
<%= link_to story_path(@featured_story), class: "block relative carousel-item active" do %>
<div class="aspect-[16/6] bg-gray-200">
<div class="h-96 max-h-96 bg-gray-200 overflow-hidden">
<%= render "assets/display_image",
resource: @featured_story,
extra_image_classes: "!w-full h-full object-cover",
variant: :hero %>
</div>
<!-- Blue Sector Box on Top Left -->
Expand Down
Loading