feat: Add finch update-finch command#1451
Draft
cartrius wants to merge 1 commit intorunfinch:mainfrom
Draft
Conversation
sondavidb
reviewed
Jul 10, 2025
Contributor
There was a problem hiding this comment.
Left quite a few comments (it's a pretty big change!) — overall really happy with the general flow/direction of it, just a few parts that I think need a little more attention. Excited to get this change out 🙂
Tests are failing but it seems to be because you were using the wrong gomock, if you just change that import the testing suite should run so don't worry too much about all the red lol
cartrius
force-pushed
the
update-finch
branch
6 times, most recently
from
38f732b to
88794ec
Compare
sondavidb
reviewed
Jul 16, 2025
cartrius
force-pushed
the
update-finch
branch
2 times, most recently
from
a299c1a to
f1cd49b
Compare
sondavidb
reviewed
Jul 23, 2025
Contributor
There was a problem hiding this comment.
It would probably be good practice if we can get this parallelized. Maybe we can take it as a followup?
Contributor
|
ubuntu tests failing I think are not an issue with the PR since we're seeing failures across the board |
sondavidb
previously approved these changes
Jul 23, 2025
sondavidb
previously approved these changes
Jul 28, 2025
Signed-off-by: Cartrius Phipps <cartrius@amazon.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
finch update-finchcommand to allow users to update Finch to the newest release through the CLI. This will download and install the pkg/msi with the newest version of Finch. This feature supports users on MacOS and Windows. Linux users should continue to use package managers--installor-iflag to install. The default behavior offinch update-finchis to check for an update instead of immediately installing, for user confirmation/safety.Testing done:
Added unit-tests for newly created
finch update-finchUpdated finch locally (on darwin/aarch64)
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.