Open
Conversation
Contributor
Author
|
This draft does not yet fully build with edition 2024 marked on all crates. |
The lifetime change is due to a lint error from clippy that did not find this problem in prior versions. The change itself shouldn't effect code depending on the cortex-m crate.
wt
force-pushed
the
update_msrv
branch
15 times, most recently
from
6092f57 to
b7bfb5b
Compare
wt
force-pushed
the
update_msrv
branch
4 times, most recently
from
b7bfb5b to
14b926e
Compare
I also explicitly set the rustfmt style to 2021 to prevent formatting churn in this same commit.
Needed to update the assembled libs because the formatting touched the asm boilerplate.
Contributor
Author
|
I think we should update the asm toolchain to the latest stable. Is there any reason not to do that? |
Contributor
|
I'd actually like to drop the asm blobs. I cannot believe anyone is seriously relying on them in this day and age. |
diondokter
approved these changes
Mar 11, 2026
Contributor
Agreed, as longs as the inline-asm feature in cargo remains, it shouldn't be a breaking change. So remove the blobs, and remove all cfgs using inline-asm. But strictly speaking that could or maybe even should be a different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #626