Rollup of 8 pull requests by JonathanBrouwer · Pull Request #153658 · rust-lang/rust

JonathanBrouwer · 2026-03-10T13:59:41Z

Successful merges:

Implement coercions between &pin (mut|const) T and &(mut) T when T: Unpin #149130 (Implement coercions between &pin (mut|const) T and &(mut) T when T: Unpin)
Pass -pg to linker when using -Zinstrument-mcount #152457 (Pass -pg to linker when using -Zinstrument-mcount)
Allow ./x test to run tests without doc tests and without benchmarks #153143 (Allow ./x test to run tests without doc tests and without benchmarks)
scalable vector: type renames and simple checks #153653 (scalable vector: type renames and simple checks)
fix: don't suggest replacing env!("CARGO_BIN_NAME") with itself #152302 (fix: don't suggest replacing env!("CARGO_BIN_NAME") with itself)
Move Spanned. #153641 (Move Spanned.)
Avoid projection-only suggestions for inherent assoc types #153643 (Avoid projection-only suggestions for inherent assoc types)
triagebot: remove myself from some mention groups #153657 (triagebot: remove myself from some mention groups)

Clang and gcc use this option to control linking behavior too. Some targets need to be linked against a special crt which enables profiling at runtime. This makes using gprof a little easier with Rust binaries. Otherwise, rustc must be passed `-Clink-args=-pg` to ensure the correct startup code is linked.

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

Use `coerce_to_pin_ref` and `coerce_pin_ref_to_ref` instead.

- `./x run generate-completions` - Search and replace `--no-doc` with `--all-targets` This is to keep the behaviour the same. - Document `./x test --tests` in `rustc-dev-guide` - Add change info

Introduces a new check in `rustc_hir_analysis` enforcing that tuples of scalable vectors should only up to eight vectors.

Renaming to remove any ambiguity as to what "vector" refers to in this context

Renaming to remove any ambiguity as to what "vector" refers to in this context.

I haven't worked in these areas for a little while, but happy to still be pinged if someone wanted.

…ackh726 Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin` This allows the following (mutual) coercions when `T: Unpin`: - `&T` <-> `Pin<&T>` - `&mut T` <-> `Pin<&mut T>` - `&mut T` -> `Pin<&T>` - `Pin<&mut T>` -> `&T` Part of [Pin Ergonomics](rust-lang#130494).

Pass -pg to linker when using -Zinstrument-mcount This selects a slightly different crt on gnu targets which enables the profiler within glibc. This makes using gprof a little easier with Rust binaries. Otherwise, rustc must be passed `-Clink-args=-pg` to ensure the correct startup code is linked.

@bjorn3

…s, r=Mark-Simulacrum,kobzol Allow `./x test` to run tests without doc tests and without benchmarks # Problem For Ferrocene we would like to run only the `coretests` and `alloctests` test suites when measuring code coverage. Running `corebenches` and `allocbenches` would alter the numbers, which is not compliant with the certification. This is currently not possible in bootstrap. By default `./x test` runs unit, integration and doc tests. `./x test --doc` only runs doc tests. So far, so good. The problem is that while `./x test --no-doc` stops bootstrap from executing doc tests, it surprisingly starts executing benchmarks (next to examples and bins as well). It basically behaves like `cargo test --all-targets`. # Solution This PR renames the existing `--no-doc` flag to `--all-targets` and keeps the same behaviour as before. Unfortunately it is not possible to internally switch from `cargo --bins --examples --tests --benches` to `cargo --all-targets` because it will fail e.g. `./x test library/alloc --all-targets` with an error like "use of unstable library feature `test`". Additionally, this PR add a `./x test --tests` flag (equivalent to `cargo test --tests`) that only executes unit and integration tests. Both changes we are doing in https://github.com/ferrocene/ferrocene anyways, but believe that they may be useful for other people as well and therefore would like to contribute them. Note that this PR does _not_ change the behaviour of either `./x test` or `./x test --doc`. ## Note on `test = true` While this change enables bootstrap to run tests without doc tests and without benchmarks, executing `./x test library/core library/alloc --tests` will still build and execute `corebenches` and `allocbenches`. What?! 😱 Why all of this effort to enable it then? Good question! The reason they are still executed is, that they are marked with `test = true` in their respective `Cargo.toml` ([corebenches](https://github.com/rust-lang/rust/blob/3f9853562c73af38a5e6af8b0da1b2734a327e19/library/coretests/Cargo.toml#L24), [allocbenches](https://github.com/rust-lang/rust/blob/3f9853562c73af38a5e6af8b0da1b2734a327e19/library/alloctests/Cargo.toml#L32)). @bjorn3 mentioned that it is important for upstream that those benchmarks are executed by default, even if no `./x --all-targets` is passed. This is perfectly possible with this PR. Benchmarks marked with `test = true` will be executed when calling either of `./x test`, `./x test --tests` or `./x --all-targets`. Therefore this PR does not include a commit to change that. We will just do this change in https://github.com/ferrocene/ferrocene. ## Open questions ### Error message I added one commit that adds an error message if a user passes `--no-doc` and points them to `--all-targets` and `--tests`. I think it might be nice to have, but if you think it is not necessary, I can remove it. # How to test this change You can see the change in action by running `./x test library/alloc --tests` and `./x test library/alloc --all-targets`. The first will execute `alloctests` and `allocbenches` (which is marked with `test = true`), while the second will additionally run `benches/vec_deque_append.rs` (which is _not_ marked with `test = true`).

@lqd

scalable vector: type renames and simple checks Split out from rust-lang#153286 Per rust-lang#153286 (comment), renames `VectorKind` type to `SimdVectorKind` and `BackendRepr::ScalableVector` to `BackendRepr::SimdScalableVector`. Also adds a new check in `rustc_hir_analysis` enforcing that tuples of scalable vectors should only up to eight vectors. r? @lqd

@rustbot

fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself Some environment variables (e.g. `CARGO_BIN_NAME`) are only available for some targets ([Cargo Targets](https://doc.rust-lang.org/cargo/reference/cargo-targets.html), [§ Environment variables Cargo sets for crates](https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates)), and the current diagnostic when copy-pasting code from a binary to a library is kinda confusing: ```rs const _: &str = env!("CARGO_BIN_NAME"); ``` Before: ``` error: environment variable `CARGO_BIN_NAME` not defined at compile time --> lib.rs:1:17 | 1 | const _: &str = env!("CARGO_BIN_NAME"); | ^^^^^^^^^^^^^^^^^^^^^^ | = help: there is a similar Cargo environment variable: `CARGO_BIN_NAME` ``` After: ``` error: environment variable `CARGO_BIN_NAME` not defined at compile time --> lib.rs:1:17 | 1 | const _: &str = env!("CARGO_BIN_NAME"); | ^^^^^^^^^^^^^^^^^^^^^^ | = help: `CARGO_BIN_NAME` may not be available for the current Cargo target = help: Cargo sets build script variables at run time. Use `std::env::var("CARGO_BIN_NAME")` instead ``` @rustbot label +T-compiler +A-diagnostics +D-confusing

@JonathanBrouwer

…Brouwer Move `Spanned`. It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic. r? @JonathanBrouwer

Avoid projection-only suggestions for inherent assoc types Fixes rust-lang#153539. Type mismatch diagnostics in `note_and_explain_type_err` currently route both `ty::Projectio`n and `ty::Inherent` through the same associated-type suggestion path. For inherent associated types, that path can reach helpers that are only valid for trait projections.

…co-diags, r=lqd triagebot: remove myself from some mention groups I haven't worked in these areas for a little while, but happy to still be pinged if someone wanted.

rust-bors · 2026-03-10T15:01:45Z

💔 Test for 61e2a12 failed: CI. Failed jobs:

auto - dist-armv7-linux (web logs, enhanced plaintext logs)
auto - x86_64-gnu-llvm-21-2 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-03-10T15:05:36Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (95007204KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
set -ex

# Run a subset of tests. Used to run tests in parallel in multiple jobs.

# When this job partition is run as part of PR CI, skip tidy to allow revealing more failures. The
# dedicated `tidy` job failing won't block other PR CI jobs from completing, and so tidy failures
# shouldn't inhibit revealing other failures in PR CI jobs.
if [ "$PR_CI_JOB" == "1" ]; then
  echo "PR_CI_JOB set; skipping tidy"
  SKIP_TIDY="--skip tidy"
fi

../x.py --stage 2 test \
  ${SKIP_TIDY:+$SKIP_TIDY} \
  --skip compiler \
  --skip src
#!/bin/bash

set -ex

# Run a subset of tests. Used to run tests in parallel in multiple jobs.

# When this job partition is run as part of PR CI, skip tidy to allow revealing more failures. The
# dedicated `tidy` job failing won't block other PR CI jobs from completing, and so tidy failures
# shouldn't inhibit revealing other failures in PR CI jobs.
if [ "$PR_CI_JOB" == "1" ]; then
  echo "PR_CI_JOB set; skipping tidy"
  SKIP_TIDY="--skip tidy"
fi

../x.py --stage 2 test \
  ${SKIP_TIDY:+$SKIP_TIDY} \
  --skip tests \
  --skip coverage-map \
  --skip coverage-run \
  --skip library \
  --skip tidyselftest
---
##[endgroup]
Image input checksum b673b5d2315f6fc680181e6bfd5ada11b531ea5d5547d8ba078117bb1b09304d77a2d6acd8d5d98323a4f5d2676f8e4c870b834d077ca891c6ee00d8d451a4b4
##[group]Building docker image for x86_64-gnu-llvm-21
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": context deadline exceeded (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

rust-log-analyzer · 2026-03-10T15:31:12Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (95909292KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

JonathanBrouwer · 2026-03-10T15:58:24Z

@bors retry

…uwer Rollup of 8 pull requests Successful merges: - #149130 (Implement coercions between `&pin (mut|const) T` and `&(mut) T` when `T: Unpin`) - #152457 (Pass -pg to linker when using -Zinstrument-mcount) - #153143 (Allow `./x test` to run tests without doc tests and without benchmarks) - #153653 (scalable vector: type renames and simple checks) - #152302 (fix: don't suggest replacing `env!("CARGO_BIN_NAME")` with itself) - #153641 (Move `Spanned`.) - #153643 (Avoid projection-only suggestions for inherent assoc types) - #153657 (triagebot: remove myself from some mention groups)

rust-bors · 2026-03-10T16:07:23Z

💔 Test for 3be5a0b failed: CI. Failed jobs:

auto - dist-various-2 (web logs, enhanced plaintext logs)
auto - x86_64-gnu-llvm-20 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-03-10T16:16:01Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

/dev/sda15      105M  6.2M   99M   6% /boot/efi
tmpfs           1.6G   12K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (95909308KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

JonathanBrouwer · 2026-03-10T17:05:29Z

Closing in favour of #153665

rust-bors · 2026-03-10T17:05:33Z

This pull request was unapproved due to being closed.

ShE3py and others added 25 commits February 7, 2026 17:42

fix: don't suggest replacing env!("CARGO_BIN_NAME") with itself

57650ee

Move Spanned.

1b85b55

It's defined in `rustc_span::source_map` which doesn't make any sense because it has nothing to do with source maps. This commit moves it to the crate root, a more sensible spot for something this basic.

add regression test for inherent assoc type mismatch ICE

c9fc358

avoid projection-only suggestions for inherent assoc types

a92006f

Support coercion between references and pinned references

8caaf1d

Remove coerce_maybe_pinned_ref.

3f75db3

Use `coerce_to_pin_ref` and `coerce_pin_ref_to_ref` instead.

Retain the types differ in mutability diagnostics

7be286e

Add ObligationCauseCode::Coercion to the Unpin obligation

d38c8c0

use #![expect(incomplete_features)]

db1060e

Allow running unit/integration tests without doc tests and benches

9d64077

Reflect removal of --no-doc in documentation

2a2cafa

- `./x run generate-completions` - Search and replace `--no-doc` with `--all-targets` This is to keep the behaviour the same. - Document `./x test --tests` in `rustc-dev-guide` - Add change info

Add ./x test --no-doc back and print a warning

c555edb

hir_analysis: check number of vectors in tuples

f760fdd

Introduces a new check in `rustc_hir_analysis` enforcing that tuples of scalable vectors should only up to eight vectors.

abi: s/ScalableVector/SimdScalableVector

db5e2dc

Renaming to remove any ambiguity as to what "vector" refers to in this context

abi: s/VectorKind/SimdVectorKind

b767499

Renaming to remove any ambiguity as to what "vector" refers to in this context.

triagebot: remove myself from some mention groups

1384f66

I haven't worked in these areas for a little while, but happy to still be pinged if someone wanted.

Rollup merge of rust-lang#153657 - davidtwco:triagebot-remove-davidtw…

a2315fe

…co-diags, r=lqd triagebot: remove myself from some mention groups I haven't worked in these areas for a little while, but happy to still be pinged if someone wanted.

rust-bors bot added the rollup A PR which is a rollup label Mar 10, 2026

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026

rust-bors bot mentioned this pull request Mar 10, 2026

Rollup of 13 pull requests #153665

Closed

JonathanBrouwer closed this Mar 10, 2026

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 10, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests#153658

Rollup of 8 pull requests#153658
JonathanBrouwer wants to merge 25 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-UdxIqUn

JonathanBrouwer commented Mar 10, 2026 •

edited by rustbot

Loading

Uh oh!

rust-bors bot commented Mar 10, 2026

Uh oh!

rust-log-analyzer commented Mar 10, 2026

Uh oh!

rust-log-analyzer commented Mar 10, 2026

Uh oh!

JonathanBrouwer commented Mar 10, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 10, 2026

Uh oh!

rust-log-analyzer commented Mar 10, 2026

Uh oh!

JonathanBrouwer commented Mar 10, 2026

Uh oh!

rust-bors bot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

JonathanBrouwer commented Mar 10, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors bot commented Mar 10, 2026

Uh oh!

rust-log-analyzer commented Mar 10, 2026

Uh oh!

rust-log-analyzer commented Mar 10, 2026

Uh oh!

JonathanBrouwer commented Mar 10, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 10, 2026

Uh oh!

rust-log-analyzer commented Mar 10, 2026

Uh oh!

JonathanBrouwer commented Mar 10, 2026

Uh oh!

rust-bors bot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

JonathanBrouwer commented Mar 10, 2026 •

edited by rustbot

Loading