perf(store): optimize UpdateReadSet allocation pattern#2852
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Store value directly on first insert instead of creating an empty slice
then appending, saving one allocation per new readset key. In the common
case (new key read for the first time), this eliminates the intermediate
empty [][]byte{} allocation.
Before: readset[key] = [][]byte{} → append(readset[key], value) (2 allocs)
After: readset[key] = [][]byte{value} (1 alloc)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2852 +/- ##
===========================================
+ Coverage 48.31% 57.10% +8.78%
===========================================
Files 671 2088 +1417
Lines 50574 171079 +120505
===========================================
+ Hits 24437 97701 +73264
- Misses 23998 64697 +40699
- Partials 2139 8681 +6542
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
pdrobnjak
force-pushed
the
perf/optimize-updatereadset-alloc
branch
from
de1b10e to
9581921
Compare
pdrobnjak
force-pushed
the
perf/lazy-init-sorted-cache
branch
from
6ac2e41 to
4a4adcb
Compare
pdrobnjak
changed the title
UpdateReadSet allocation pattern
stevenlanders
approved these changes
Feb 11, 2026
arajasek
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize allocation pattern in
UpdateReadSetto reduce GC pressure.🤖 Generated with Claude Code