Skip to content

perf(store): optimize UpdateReadSet allocation pattern #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdrobnjak merged 2 commits into from
Feb 11, 2026
Merged

perf(store): optimize UpdateReadSet allocation pattern #2852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9581921
perf(store): optimize UpdateReadSet allocation pattern
pdrobnjak Feb 9, 2026
c34db68
Merge branch 'main' into perf/optimize-updatereadset-alloc
pdrobnjak Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions sei-cosmos/store/multiversion/mvkv.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,22 +385,19 @@ func (store *VersionIndexedStore) WriteEstimatesToMultiVersionStore() {
}

func (store *VersionIndexedStore) UpdateReadSet(key []byte, value []byte) {
// TODO: make readset a list of byte slices, and store the value if it's a new value
// add to readset
keyStr := string(key)
// TODO: maybe only add if not already existing?
if _, ok := store.readset[keyStr]; !ok {
// if the entry doesnt exist, make a new empty slice
store.readset[keyStr] = [][]byte{}
existing, ok := store.readset[keyStr]
if !ok {
// fast path: new key, store value directly (avoids empty slice + append)
store.readset[keyStr] = [][]byte{value}
return
}
for _, readsetVal := range store.readset[keyStr] {
for _, readsetVal := range existing {
if bytes.Equal(value, readsetVal) {
// this means we have already added this value to our readset, so we continue
return
}
}
// if we get here, that means we have a new readset val, so we append it to the slice
store.readset[keyStr] = append(store.readset[keyStr], value)
store.readset[keyStr] = append(existing, value)
}

// Write implements types.CacheWrap so this store can exist on the cache multi store
Expand Down
Loading