feat: add /logs endpoint verification to smoke tests#51
Merged
Conversation
Verify global /logs and per-entity /apps/{id}/logs endpoints return
non-empty data in all 3 demo smoke tests.
Closes #44
There was a problem hiding this comment.
Pull request overview
Adds smoke-test coverage to verify the gateway’s logs API is functional across all three demos, aligning with issue #44’s goal of showcasing /logs support.
Changes:
- Add
GET /logsverification (expects200and non-empty.items) to each demo’s smoke test. - Add
GET /apps/{entity}/logsverification for a representative app in each demo (e.g.,lidar-sim,medkit-gateway).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/smoke_test.sh | Adds /logs and /apps/lidar-sim/logs assertions to the sensor_diagnostics smoke test. |
| tests/smoke_test_turtlebot3.sh | Adds /logs and /apps/medkit-gateway/logs assertions to the turtlebot3 demo smoke test. |
| tests/smoke_test_moveit.sh | Adds /logs and /apps/medkit-gateway/logs assertions to the moveit demo smoke test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The gateway only exposes logs per-entity (e.g. /apps/{id}/logs), not
a global /logs endpoint. Use anomaly-detector for sensor demo (active
logger) and medkit-gateway for turtlebot3/moveit.
DRY up the repeated api_get + jq '.items | length > 0' pattern used across data, configurations, and logs checks in all 3 demos.
anomaly-detector and lidar-sim don't emit /rosout logs in CI, so use medkit-gateway which always has log entries from startup.
mfaferek93
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add logs endpoint verification to all 3 demo smoke tests (sensor_diagnostics, turtlebot3, moveit). Each test now checks:
GET /logsreturns 200 with non-emptyitemsGET /apps/{entity}/logsreturns 200 with non-emptyitems(lidar-sim for sensor demo, medkit-gateway for turtlebot3/moveit)Related Issue
closes #44
Checklist