[Demon Hunter] Fix Meteoric Rise soul fragment spawning during Fel Devastation #10920
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tick() method used d->num_ticks() (a constant) in both the division and modulo, making the spawn condition always true. With 4 ticks and 3 target fragments: 4/3=1, 4%1=0 -> always true, spawning 4 fragments instead of 3. Replace with integer boundary crossing: on each tick, compare how many fragments should have spawned before vs after this tick. This distributes exactly N fragments across M ticks evenly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Meteoric Rise tick callback uses an integer division algorithm that always evaluates to true, spawning a soul fragment on every tick instead of distributing N fragments across M ticks.
With 4 ticks and 3 target fragments:
ticks_per_soul_fragment = 4/3 = 1(int),4 % 1 == 0→ always true → 4 fragments instead of 3.Fix
Replace with integer boundary crossing that distributes exactly N fragments across M ticks:
Verified:
current_tickis 1-based (incremented atdot.cpp:1079beforetick()at line 1092),tick_on_application = falsefor Fel Devastation. With 4 ticks/3 fragments: spawns on ticks 2, 3, 4 (total 3). With 6 ticks/3 fragments: spawns on ticks 2, 4, 6 (evenly spaced).