Skip to content

[Demon Hunter] Fix Meteoric Rise soul fragment spawning during Fel Devastation #10920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToppleTheNun merged 1 commit into from
Feb 12, 2026
Merged

[Demon Hunter] Fix Meteoric Rise soul fragment spawning during Fel Devastation #10920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions engine/class_modules/sc_demon_hunter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4114,8 +4114,9 @@ struct fel_devastation_t : public final_breath_trigger_t<demon_hunter_spell_t>

if ( p()->talent.annihilator.meteoric_rise->ok() )
{
int ticks_per_soul_fragment = as<int>( d->num_ticks() / soul_fragments_from_meteoric_rise );
if ( d->num_ticks() % ticks_per_soul_fragment == 0 )
int expected_before = ( d->current_tick - 1 ) * soul_fragments_from_meteoric_rise / d->num_ticks();
int expected_after = d->current_tick * soul_fragments_from_meteoric_rise / d->num_ticks();
if ( expected_after > expected_before )
{
p()->spawn_soul_fragment( p()->proc.soul_fragment_from_meteoric_rise, soul_fragment::LESSER );
}
Expand Down
Loading