[fix][gcp] Update GCP graph relationships to include instances and disks#2334
Open
drwicid wants to merge 1 commit intosomeengineering:mainfrom
Open
[fix][gcp] Update GCP graph relationships to include instances and disks#2334drwicid wants to merge 1 commit intosomeengineering:mainfrom
drwicid wants to merge 1 commit intosomeengineering:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #2333 two missing graph relationships in the GCP compute collector.
GcpAddress.connect_in_graph()now linksusersentries back toGcpInstancenodes.GcpInstance.connect_in_graph()now links attached disksourcevalues toGcpDisknodes.The change keeps the existing per-resource graph connection model and closes confirmed topology gaps without broadening the collector design.
Files Changed
plugins/gcp/fix_plugin_gcp/resources/compute.pyplugins/gcp/test/test_compute.pyValidation
toxsuccessfully [tox was noisy, I will have a separate PR to propose changes]