Open
Conversation
12 tasks
vdice
force-pushed
the
docs/misc-updates
branch
2 times, most recently
from
cde7475 to
9153d09
Compare
Signed-off-by: Vaughn Dice <vdice@akamai.com>
vdice
force-pushed
the
docs/misc-updates
branch
from
9153d09 to
51d3255
Compare
Shunpoco
reviewed
Feb 7, 2026
| * `spec.runtimeClass.name`: Name of the Kubernetes RuntimeClass | ||
| - This name should match what is expected by shim-specific operator(s) on the cluster | ||
| - For example, the [Spin Operator](https://github.com/spinframework/spin-operator) utilizes a [SpinAppExecutor](https://www.spinkube.dev/docs/reference/spin-app-executor/) resource | ||
| to run Spin Apps; the default RuntimeClass name it expects can be seen [here](https://github.com/spinframework/spin-operator/blob/main/config/samples/spin-shim-executor.yaml) |
Contributor
There was a problem hiding this comment.
IMO: Can we describe a generated runtime class has Scheduling.NodeSelector which derived from Shim CR's spec.nodeSelector (in this doc or shim.md)? I think the Scheduling is very important. If a runtimeclass doesn't have it (by user's mis-modification or else), a Spin pod could be allocated anywhere including a non-spin cluster
|
|
||
| - **M1: [RCM MVP for Spinkube](https://github.com/spinframework/runtime-class-manager/milestone/1)** | ||
| This milestone is about getting RCM to a state where Spinkube can rely on RCM and use it as a dependency instead of Kwasm. This means, that the focus is on managing lifecycle of [containerd-shim-spin](https://github.com/spinframework/containerd-shim-spin) on nodes. | ||
| This milestone is about getting RCM to a state where Spinkube can rely on RCM and use it as a dependency instead of Kwasm. This means, that the focus is on managing lifecycle of [containerd-shim-spin](https://github.com/spinframework/containerd-shim-spin) on nodes. _This is now complete._ |
Contributor
There was a problem hiding this comment.
Suggested change
| This milestone is about getting RCM to a state where Spinkube can rely on RCM and use it as a dependency instead of Kwasm. This means, that the focus is on managing lifecycle of [containerd-shim-spin](https://github.com/spinframework/containerd-shim-spin) on nodes. _This is now complete._ | |
| This milestone is about getting RCM to a state where Spinkube can rely on RCM and use it as a dependency instead of Kwasm. This means, that the focus is on managing lifecycle of [containerd-shim-spin](https://github.com/spinframework/containerd-shim-spin) on nodes. _This is now complete._ |
Contributor
|
@vdice I'm not a reviewer/maintainer of the repository (of course you know!), but let me put small comments above 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Some minimal README and doc updates in preparation for RCM going "prime time" as the default wasm/runtimeclass installer for SpinKube (ref spinframework/spinkube-docs#339)