-
Notifications
You must be signed in to change notification settings - Fork 13
docs(*): misc updates #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| ## RuntimeClass | ||
|
|
||
| The Operator is designed to create a RuntimeClass for each shim. `spec.runtimeClass` configures the RuntimeClass that will be created. | ||
| Runtime Class Manager is in charge of creating a [RuntimeClass](https://kubernetes.io/docs/concepts/containers/runtime-class) for each [Shim](./shim.md) resource created on the cluster. | ||
|
|
||
| The `spec.runtimeClass` section of the Shim resource configures the RuntimeClass that will be created. | ||
|
|
||
| * `spec.runtimeClass.name`: Name of the Kubernetes RuntimeClass | ||
| - This name should match what is expected by shim-specific operator(s) on the cluster | ||
| - For example, the [Spin Operator](https://github.com/spinframework/spin-operator) utilizes a [SpinAppExecutor](https://www.spinkube.dev/docs/reference/spin-app-executor/) resource | ||
| to run Spin Apps; the default RuntimeClass name it expects can be seen [here](https://github.com/spinframework/spin-operator/blob/main/config/samples/spin-shim-executor.yaml) | ||
| * `spec.runtimeClass.handler`: Name of the shim as it is referenced in the containerd config | ||
|
|
||
| **Discuss later:** | ||
|
|
||
| - At this point in time `spec.RuntimeClass` is a mendatory field | ||
| - pro: it will make sure a RuntimeClass exist for the shim thats going to be installed | ||
| - con: possible that runtimeclass is created by other means | ||
| - Should `spec.RuntimeClass.handler` be optional? Is it even required? | ||
| > Note: The RuntimeClass's `scheduling.nodeSelector` will be set to the same key/value pair as configured in the [Shim](./shim.md) resource. This ensures that applications targeting the RuntimeClass are only scheduled on nodes where the corresponding runtime shim has been installed. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ## Shim | ||
|
|
||
| Runtime Class Manager operates on `Shim` custom resources based on the [Shim CRD](../config/crd/bases/runtime.spinkube.dev_shims.yaml). | ||
|
|
||
| Whenever a Shim is created, updated or deleted, Runtime-Class-Manager will perform the necessary actions, e.g. creating, updating or removing the associated [RuntimeClass](./runtimeclass.md), installing or removing shim binaries on any [Nodes](https://kubernetes.io/docs/concepts/architecture/nodes/) labeled with a corresponding to its `nodeSelector`, etc. | ||
|
|
||
| ### Configuration | ||
|
|
||
| For full, detailed configuration options, see the [Shim CRD](../config/crd/bases/runtime.spinkube.dev_shims.yaml). Here we point out a few pertinent items. | ||
|
|
||
| * `spec.nodeSelector`: The label key and value applied to Nodes where this particular shim should be installed | ||
| * `spec.fetchStrategy`: The strategy for fetching the shim binary | ||
| * `spec.fetchStrategy.type`: `anonymousHttp` is the only option currently supported. | ||
| * `spec.fetchStrategy.anonHttp.location`: The URL where the shim binary can be downloaded | ||
| * `spec.containerdRuntimeOptions`: Options specific to the shim that should be added to the containerd configuration | ||
|
|
||
| ### Operation | ||
|
|
||
| You may observe the "install" and "uninstall" [Jobs](https://kubernetes.io/docs/concepts/workloads/controllers/job/) responsible for downloading and installing (or uninstalling) the shim binary. These will run on every Node that matches the Shim's `nodeSelector`. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.