Skip to content

Gate Docker login and snstage image usage on streamnativebot actor#2029

Merged
mattisonchao merged 5 commits intomasterfrom
copilot/remove-docker-login-step
Mar 18, 2026
Merged

Gate Docker login and snstage image usage on streamnativebot actor#2029
mattisonchao merged 5 commits intomasterfrom
copilot/remove-docker-login-step

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

The Docker login and private snstage/pulsar-all image were unconditionally required for all CI runs. This gates both on github.actor == 'streamnativebot', allowing external contributors to run CI against the public apachepulsar/pulsar-all image without credentials.

  • Dockerfile: Accept configurable base image via PULSAR_IMAGE build arg, defaulting to apachepulsar/pulsar-all
  • run-integration-tests.sh: Forward PULSAR_IMAGE env var as --build-arg to docker build
  • CI workflows: Conditionally set PULSAR_IMAGE per step and gate Docker login on actor
- name: Login SN docker hub
  if: github.actor == 'streamnativebot'
  run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
- name: Run tests
  run: scripts/run-integration-tests.sh
  env:
    PULSAR_IMAGE: ${{ github.actor == 'streamnativebot' && 'snstage/pulsar-all' || 'apachepulsar/pulsar-all' }}
  • Pulsar version: Updated default from 4.1.0.10 to 4.1.3

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

The CI workflows logged in to Docker Hub to pull a private StreamNative
image (snstage/pulsar-all). This is no longer needed since the public
Apache Pulsar image (apachepulsar/pulsar-all) can be used instead.

- Remove docker login steps from all 5 CI workflow files
- Switch Dockerfile base image from snstage/pulsar-all to apachepulsar/pulsar-all
- Update default Pulsar version from 4.1.0.10 to 4.0.3

Co-authored-by: zymap <24502569+zymap@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove docker login step from CI Remove Docker login from CI by switching to public Apache Pulsar images Mar 18, 2026
Copilot AI requested a review from zymap March 18, 2026 02:25
Co-authored-by: zymap <24502569+zymap@users.noreply.github.com>
Copilot AI changed the title Remove Docker login from CI by switching to public Apache Pulsar images Remove Docker login from CI and switch to public Apache Pulsar images Mar 18, 2026
@github-actions
Copy link
Copy Markdown

@Copilot:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link
Copy Markdown

@Copilot:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description labels Mar 18, 2026
@zymap zymap marked this pull request as ready for review March 18, 2026 02:36
@zymap zymap requested review from a team, mattisonchao and nlu90 as code owners March 18, 2026 02:36
@zymap zymap marked this pull request as draft March 18, 2026 02:37
…treamnativebot'

Co-authored-by: zymap <24502569+zymap@users.noreply.github.com>
Copilot AI changed the title Remove Docker login from CI and switch to public Apache Pulsar images Switch CI to public Apache Pulsar 4.1.3 image, gate Docker login on streamnativebot Mar 18, 2026
…-all for others

Co-authored-by: zymap <24502569+zymap@users.noreply.github.com>
Copilot AI changed the title Switch CI to public Apache Pulsar 4.1.3 image, gate Docker login on streamnativebot Gate Docker login and snstage image usage on streamnativebot actor Mar 18, 2026
@zymap zymap marked this pull request as ready for review March 18, 2026 03:05
@mattisonchao mattisonchao merged commit 2aee266 into master Mar 18, 2026
12 checks passed
@mattisonchao mattisonchao deleted the copilot/remove-docker-login-step branch March 18, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-info-missing This pr needs to mark a document option in description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants