Skip to content

Gate Docker login and snstage image usage on streamnativebot actor #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattisonchao merged 5 commits into from
Mar 18, 2026
Merged

Gate Docker login and snstage image usage on streamnativebot actor #2029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ed816e
Initial plan
Copilot Mar 18, 2026
05bf76a
Remove Docker login from CI by switching to public Apache Pulsar images
Copilot Mar 18, 2026
81b27e6
Update Pulsar version from 4.0.3 to 4.1.3
Copilot Mar 18, 2026
ebb65a9
Re-add Docker login in CI workflows conditioned on github.actor == 's…
Copilot Mar 18, 2026
d02eed5
Use snstage/pulsar-all image for streamnativebot, apachepulsar/pulsar…
Copilot Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci-auth-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,13 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Login SN docker hub
if: github.actor == 'streamnativebot'
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
- name: Run token tests
run: scripts/run-integration-tests.sh token
env:
PULSAR_IMAGE: ${{ github.actor == 'streamnativebot' && 'snstage/pulsar-all' || 'apachepulsar/pulsar-all' }}
- name: Run TLS tests
run: scripts/run-integration-tests.sh tls
env:
PULSAR_IMAGE: ${{ github.actor == 'streamnativebot' && 'snstage/pulsar-all' || 'apachepulsar/pulsar-all' }}
3 changes: 3 additions & 0 deletions .github/workflows/ci-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Login SN docker hub
if: github.actor == 'streamnativebot'
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
- uses: actions/checkout@v2
- name: Run tests
run: scripts/run-integration-tests.sh
env:
PULSAR_IMAGE: ${{ github.actor == 'streamnativebot' && 'snstage/pulsar-all' || 'apachepulsar/pulsar-all' }}
9 changes: 9 additions & 0 deletions .github/workflows/ci-functions-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Login SN docker hub
if: github.actor == 'streamnativebot'
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
- name: Set up Go 1.25.8
uses: actions/setup-go@v6
Expand All @@ -22,13 +23,16 @@ jobs:
uses: actions/checkout@v2
- name: Function tests
run: scripts/run-integration-tests.sh function
env:
PULSAR_IMAGE: ${{ github.actor == 'streamnativebot' && 'snstage/pulsar-all' || 'apachepulsar/pulsar-all' }}
- name: Setup tmate session
if: failure()
uses: mxschmitt/action-tmate@v3
sink-tests:
runs-on: ubuntu-latest
steps:
- name: Login SN docker hub
if: github.actor == 'streamnativebot'
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
- name: Set up Go 1.25.8
uses: actions/setup-go@v6
Expand All @@ -39,10 +43,13 @@ jobs:
uses: actions/checkout@v2
- name: Sink tests
run: scripts/run-integration-tests.sh sink
env:
PULSAR_IMAGE: ${{ github.actor == 'streamnativebot' && 'snstage/pulsar-all' || 'apachepulsar/pulsar-all' }}
source-tests:
runs-on: ubuntu-latest
steps:
- name: Login SN docker hub
if: github.actor == 'streamnativebot'
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
- name: Set up Go 1.25.8
uses: actions/setup-go@v6
Expand All @@ -53,3 +60,5 @@ jobs:
uses: actions/checkout@v2
- name: Source tests
run: scripts/run-integration-tests.sh source
env:
PULSAR_IMAGE: ${{ github.actor == 'streamnativebot' && 'snstage/pulsar-all' || 'apachepulsar/pulsar-all' }}
1 change: 1 addition & 0 deletions .github/workflows/ci-install-script-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Login SN docker hub
if: github.actor == 'streamnativebot'
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
- name: Check out code into the Go module directory
uses: actions/checkout@v2
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci-packages-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Login SN docker hub
if: github.actor == 'streamnativebot'
run: docker login -u="${{ secrets.DOCKER_USER }}" -p="${{ secrets.DOCKER_PASSWORD}}"
- name: Set up Go 1.25.8
uses: actions/setup-go@v5
Expand All @@ -22,6 +23,8 @@ jobs:
uses: actions/checkout@v2
- name: Packages tests
run: scripts/run-integration-tests.sh packages
env:
PULSAR_IMAGE: ${{ github.actor == 'streamnativebot' && 'snstage/pulsar-all' || 'apachepulsar/pulsar-all' }}
- name: Setup tmate session
if: failure()
uses: mxschmitt/action-tmate@v3
4 changes: 3 additions & 1 deletion scripts/run-integration-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@ set -e

readonly PROJECT_ROOT=`cd $(dirname $0)/..; pwd`
readonly IMAGE_NAME=pulsarctl-test
readonly PULSAR_DEFAULT_VERSION="4.1.0.10"
readonly PULSAR_DEFAULT_VERSION="4.1.3"
readonly PULSAR_VERSION=${PULSAR_VERSION:-${PULSAR_DEFAULT_VERSION}}
readonly PULSAR_IMAGE=${PULSAR_IMAGE:-"apachepulsar/pulsar-all"}

docker build --build-arg PULSAR_VERSION=${PULSAR_VERSION} \
--build-arg PULSAR_IMAGE=${PULSAR_IMAGE} \
-t ${IMAGE_NAME} \
-f ${PROJECT_ROOT}/scripts/test-docker/Dockerfile ${PROJECT_ROOT}
case ${1} in
Expand Down
3 changes: 2 additions & 1 deletion scripts/test-docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
ARG PULSAR_IMAGE=apachepulsar/pulsar-all
ARG PULSAR_VERSION
FROM snstage/pulsar-all:$PULSAR_VERSION
FROM ${PULSAR_IMAGE}:${PULSAR_VERSION}

# use root user
USER root
Expand Down
Loading