Skip to content

Use HTTPS with credential helper for sync-versions GHA #4544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caseydavenport merged 3 commits into from
Mar 13, 2026
Merged

Use HTTPS with credential helper for sync-versions GHA #4544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4004a26
Fix Github action
caseydavenport Mar 13, 2026
9989ee4
Use HTTPS with credential helper for sync-versions GHA
caseydavenport Mar 13, 2026
e1a205d
Merge master and resolve conflicts
caseydavenport Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/sync-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,15 @@ jobs:
with:
ref: ${{ matrix.branch }}

- name: Gen versions
- name: Configure git auth
run: |
make gen-versions
git config --global credential.helper store
echo "https://marvin-tigera:${GITHUB_TOKEN}@github.com" > ~/.git-credentials
env:
MARVIN_PAT: ${{ secrets.MARVIN_PAT }}
GITHUB_TOKEN: ${{ secrets.MARVIN_PAT }}

- name: Gen versions
run: make gen-versions GIT_CLONE_URL_BASE=https://github.com/

- uses: peter-evans/create-pull-request@v6
with:
Expand Down
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ SRC_FILES+=$(shell find ./test -name '*.go')
SRC_FILES+=cmd/main.go

EXTRA_DOCKER_ARGS += -e GOPRIVATE=github.com/tigera/*
GIT_CLONE_URL_BASE?=git@github.com:
ifeq ($(GIT_USE_SSH),true)
GIT_CONFIG_SSH ?= git config --global url."ssh://git@github.com/".insteadOf "https://github.com/";
endif
Expand Down Expand Up @@ -698,7 +699,7 @@ define fetch_crds
$(eval branch := $(2))
$(eval dir := $(3))
@echo "Fetching $(dir) CRDs from $(project) branch $(branch)"
git -C .crds/$(dir) clone --depth 1 --branch $(branch) --single-branch git@github.com:$(project).git ./
git -C .crds/$(dir) clone --depth 1 --branch $(branch) --single-branch $(GIT_CLONE_URL_BASE)$(project).git ./
endef
define copy_v1_crds
$(eval dir := $(1))
Expand Down
Loading