Use HTTPS with credential helper for sync-versions GHA#4544
Merged
caseydavenport merged 3 commits intotigera:masterfrom Mar 13, 2026
Merged
Use HTTPS with credential helper for sync-versions GHA#4544caseydavenport merged 3 commits intotigera:masterfrom
caseydavenport merged 3 commits intotigera:masterfrom
Conversation
Switch the sync-versions workflow from embedding the PAT in git URL rewrites to using the credential.helper store, which avoids leaking tokens in logs. Add a GIT_CLONE_URL_BASE variable to the Makefile (defaults to SSH for local dev) so the GHA can override to HTTPS.
coutinhop
reviewed
Mar 13, 2026
coutinhop
approved these changes
Mar 13, 2026
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the sync-versions workflow from embedding the PAT in git URL rewrites to using
credential.helper store, which avoids leaking tokens in logs.Add a
GIT_CLONE_URL_BASEvariable to the Makefile (defaults togit@github.com:for local dev) so the GHA can override to HTTPS while keeping SSH as the default for developers.