Skip to content

[TRUNK-17695] Document impacted targets visualization in merge graph UI#458

Open
samgutentag wants to merge 1 commit intomainfrom
sam-gutentag/impacted-targets-graph-ui
Open

[TRUNK-17695] Document impacted targets visualization in merge graph UI#458
samgutentag wants to merge 1 commit intomainfrom
sam-gutentag/impacted-targets-graph-ui

Conversation

@samgutentag
Copy link
Member

Summary

• Added "Impacted targets in the graph" subsection to the Graph view on the Monitor queue status page — covers per-PR tooltips and overlapping targets toggle
• Added "Impacted targets on the PR detail page" subsection — covers the View impacted targets modal with IMPACTS_ALL, specific targets, and no targets states

Note: The metrics filtering by impacted targets is already documented in merge-queue/administration/metrics.md, so no update needed there.

Context links

  • trunk-io/trunk2#2406, #2414, #2457, #3043, #3099 (all merged)

Files changed

  • merge-queue/using-the-queue/monitor-queue-status.md — new subsections under Graph view

Open questions

  1. Is the toggle labeled "Show impacted targets" or something else?
  2. Are there screenshots available for the graph with impacted targets enabled?
  3. Does the impacted targets modal show on PRs in Single mode, or only Parallel mode?

Test plan

  • Check GitBook preview
  • Verify link to parallel queues page works

🤖 Generated with Claude Code

Add sections for impacted targets tooltips, overlapping targets on
graph edges, and the impacted targets modal on the PR detail page.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@trunk-staging-io
Copy link

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@samgutentag samgutentag changed the title Document impacted targets visualization in merge graph UI [TRUNK-17695] Document impacted targets visualization in merge graph UI Mar 12, 2026
@claude
Copy link

claude bot commented Mar 12, 2026

Claude finished @samgutentag's task in 2m 22s —— View job


Review complete

  • Gather context
  • Read changed file
  • Review for typos, grammar, formatting, and documentation best practices
  • Post inline comments for specific issues
  • Final summary

The new documentation is clearly written and well-structured overall. A few issues to address before merging:

Blocking concerns:

  1. Open questions unresolved — The PR body flags three open questions about content accuracy (toggle label, screenshots, Single vs. Parallel mode applicability). These should be resolved before merging to avoid shipping inaccurate docs.
  2. Structural placement — The #### Impacted targets on the PR detail page subsection is nested under ### Graph view, but it describes a different part of the UI. See inline comment at line 59.

Non-blocking suggestions:

  • Line 65: IMPACTS_ALL is bold in the bullet label but unformatted in the inline reference in the same bullet. See suggestion at line 65.
  • Consider using backtick code formatting (`IMPACTS_ALL`) for the enum value throughout for semantic clarity.
  • Adding screenshots (open question ok #2) would significantly improve this section's usability.


This is useful for debugging unexpected queue ordering or understanding why specific PRs are batched together.

#### Impacted targets on the PR detail page
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structural placement concern: This subsection discusses the PR detail page, but it's nested under ### Graph view. The PR detail page is a separate UI section, documented later under ## Pull request details. Consider either:

  1. Moving this subsection under ## Pull request details, or
  2. Adding a brief note that users can access the targets modal from the graph by clicking through to a PR's detail page, to justify the placement here.

As written, readers browsing the "Graph view" section may find the PR detail page content unexpected here.


* **IMPACTS\_ALL**: The PR impacts all targets, so no parallel optimization is possible.
* **Specific targets**: A list of each target the PR impacts.
* **No targets uploaded**: No targets were provided, so the PR is treated as IMPACTS\_ALL for safety.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting inconsistency: IMPACTS_ALL is bolded (**IMPACTS\_ALL**) in the bullet label on line 63, but appears unformatted inline here. For consistency, apply the same formatting:

Suggested change
* **No targets uploaded**: No targets were provided, so the PR is treated as IMPACTS\_ALL for safety.
* **No targets uploaded**: No targets were provided, so the PR is treated as **IMPACTS\_ALL** for safety.

Alternatively, consider using backtick code formatting (`IMPACTS_ALL`) throughout, since this appears to be an enum/constant value.

When running in [Parallel mode](../optimizations/parallel-queues/), the graph view shows impacted targets information to help you understand why PRs are grouped or ordered the way they are.

* **Per-PR tooltips**: Hover over a PR node to see which targets that PR impacts.
* **Overlapping targets on edges**: Use the **Show impacted targets** toggle to display which targets overlap between connected PRs. Overlapping targets explain why PRs are in the same testing sequence — PRs with shared targets must test together.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question (from PR description): The toggle is referred to as "Show impacted targets" here. Please confirm this matches the exact label in the UI before merging — the PR body flags this as an open question.


#### Impacted targets on the PR detail page

On any PR's detail page, click **View impacted targets** to see the full list of uploaded targets. The modal shows one of three states:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question (from PR description): Does the View impacted targets modal appear for PRs in Single mode as well, or only in Parallel mode? If it's Parallel-mode-only, add a qualifier here similar to the note in the section above:

When running in Parallel mode, on any PR's detail page…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant