Skip to content

[TRUNK-17695] Document impacted targets visualization in merge graph UI #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samgutentag wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TRUNK-17695] Document impacted targets visualization in merge graph UI #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions merge-queue/using-the-queue/monitor-queue-status.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,23 @@ The view of all current PRs being tested by Trunk Merge Queue and their respecti

You can click on any shown PR to navigate to the details page for that PR.

#### Impacted targets in the graph

When running in [Parallel mode](../optimizations/parallel-queues/), the graph view shows impacted targets information to help you understand why PRs are grouped or ordered the way they are.

* **Per-PR tooltips**: Hover over a PR node to see which targets that PR impacts.
* **Overlapping targets on edges**: Use the **Show impacted targets** toggle to display which targets overlap between connected PRs. Overlapping targets explain why PRs are in the same testing sequence — PRs with shared targets must test together.
Copy link
Contributor

@claude claude bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question (from PR description): The toggle is referred to as "Show impacted targets" here. Please confirm this matches the exact label in the UI before merging — the PR body flags this as an open question.


This is useful for debugging unexpected queue ordering or understanding why specific PRs are batched together.

#### Impacted targets on the PR detail page
Copy link
Contributor

@claude claude bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structural placement concern: This subsection discusses the PR detail page, but it's nested under ### Graph view. The PR detail page is a separate UI section, documented later under ## Pull request details. Consider either:

  1. Moving this subsection under ## Pull request details, or
  2. Adding a brief note that users can access the targets modal from the graph by clicking through to a PR's detail page, to justify the placement here.

As written, readers browsing the "Graph view" section may find the PR detail page content unexpected here.


On any PR's detail page, click **View impacted targets** to see the full list of uploaded targets. The modal shows one of three states:
Copy link
Contributor

@claude claude bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open question (from PR description): Does the View impacted targets modal appear for PRs in Single mode as well, or only in Parallel mode? If it's Parallel-mode-only, add a qualifier here similar to the note in the section above:

When running in Parallel mode, on any PR's detail page…


* **IMPACTS\_ALL**: The PR impacts all targets, so no parallel optimization is possible.
* **Specific targets**: A list of each target the PR impacts.
* **No targets uploaded**: No targets were provided, so the PR is treated as IMPACTS\_ALL for safety.
Copy link
Contributor

@claude claude bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting inconsistency: IMPACTS_ALL is bolded (**IMPACTS\_ALL**) in the bullet label on line 63, but appears unformatted inline here. For consistency, apply the same formatting:

Suggested change
* **No targets uploaded**: No targets were provided, so the PR is treated as IMPACTS\_ALL for safety.
* **No targets uploaded**: No targets were provided, so the PR is treated as **IMPACTS\_ALL** for safety.

Alternatively, consider using backtick code formatting (`IMPACTS_ALL`) throughout, since this appears to be an enum/constant value.


### Health view

Select a period of time to inspect using the **Period** dropdown (default 7 days) and a **Granularity** (defaults to daily) of queue metrics
Expand Down
Loading