fix(qemu): fix terminal mess up in qemu based deployment#459
fix(qemu): fix terminal mess up in qemu based deployment#459ishaanxgupta wants to merge 2 commits intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
as per discussion in #440 (comment) |
|
Hi @ishaanxgupta, thanks for working on this. Also, u need to format the code with |
|
Sure @spline2hg |
|
@cmainas please have a look, the tests should pass this time |
|
Hello @ishaanxgupta , you will need to rebase over urunc's main branch so we can merge this. |
Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
Signed-off-by: Ishaan Gupta <ishaankone@gmail.com>
3cfa8ba to
d471664
Compare
|
Hello @ishaanxgupta , it seems there is an issue with docker. For example: |
|
@cmainas sorry, the issue is a duplicate -serial stdio flag. This PR changed qemu.go from -nographic to -display none -vga none -serial stdio -monitor null, but linux.go - MonitorCli() also appends -serial stdio -nodefaults as extra args. QEMU rejects two character devices bound to the same stdio backend. |
Yeah that is totally correct. You can remove it from Linux then. |
|
Also, please squash your commits. |
Description
With QEMU, -nographic doesn’t just “disable graphics”; it also redirects the emulated VGA/serial output to the controlling terminal (stdio) and can multiplex the QEMU monitor/serial on the same stream. That output often contains control characters / escape sequences and QEMU can leave your terminal in a weird state when it exits (so you need reset / stty sane).
Replaced -nographic with:
Related issues
LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).