Skip to content

fix(qemu): fix terminal mess up in qemu based deployment #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishaanxgupta wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(qemu): fix terminal mess up in qemu based deployment #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/unikontainers/hypervisors/qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (q *Qemu) BuildExecCmd(args types.ExecArgs, ukernel types.Unikernel) ([]str
cmdString += " -L /usr/share/qemu" // Set the path for qemu bios/data
cmdString += " -cpu host" // Choose CPU
cmdString += " -enable-kvm" // Enable KVM to use CPU virt extensions
cmdString += " -nographic -vga none" // Disable graphic output
cmdString += " -display none -vga none -serial stdio -monitor null" // Disable graphic output

if args.VCPUs > 0 {
cmdString += fmt.Sprintf(" -smp %d", args.VCPUs)
Expand Down
2 changes: 1 addition & 1 deletion pkg/unikontainers/unikernels/linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ func (l *Linux) MonitorCli() types.MonitorCliArgs {
switch l.Monitor {
case "qemu":
extraCliArgs := types.MonitorCliArgs{
OtherArgs: " -no-reboot -serial stdio -nodefaults",
Copy link
Contributor

@cmainas cmainas Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for removing -nodefaults?

OtherArgs: " -no-reboot",
}
if l.InitrdConf && l.RootFsType != "initrd" {
extraCliArgs.ExtraInitrd = urunitConfPath
Expand Down
Loading