RSDK-8814: Make module_file_info required in upload_module_file

[claude]

Summary

• Make module_file_info parameter required (non-Optional) in AppClient.upload_module_file(), since the gRPC server requires it in the first upload packet and passing None results in an INVALID_ARGUMENT error.

Test plan

• Existing test_upload_module_file test passes
• uv run make format passes
• uv run make lint passes

🤖 Generated with Claude Code

[ale7714]

We didn't need AI but I was doing some testing. Looking at the api, it's not optional https://github.com/viamrobotics/api/blob/main/proto/viam/app/v1/app.proto#L1688

[claude]

Review

The change is correct and well-scoped.

Correctness: module_file_info is sent in the first streaming message to UploadModuleFile. Protobuf would silently omit a None value, causing the server to return INVALID_ARGUMENT. Making the parameter required at the Python type level accurately reflects the server contract.

Backwards Compatibility: This is technically a breaking change — any caller passing module_file_info=None will now get a type error from pyright. However, that call was already broken at runtime (server rejection), so this is a type-level correction of a pre-existing contract violation, not a genuine regression.

Scope: Exactly two lines changed — the signature and the docstring. No refactoring, no scope creep, no unrelated changes.

Validation:

• Only src/viam/app/app_client.py is modified; gen/ is untouched.
• AppClient has no superclass defining upload_module_file, so no interface needs updating.
• Optional is still imported and used 93+ times elsewhere in the file — no stale import.
• Lint passes (ruff check).
• The existing test already exercises the only valid code path (non-None ModuleFileInfo), so no new test is needed.

No issues found. A human approver should confirm the API break is intentional and communicated to consumers.