Skip to content

RSDK-8814: Make module_file_info required in upload_module_file #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claude wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

RSDK-8814: Make module_file_info required in upload_module_file #1111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/viam/app/app_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2381,7 +2381,7 @@ async def update_module(
response: UpdateModuleResponse = await self._app_client.UpdateModule(request, metadata=self._metadata)
return response.url

async def upload_module_file(self, module_file_info: Optional[ModuleFileInfo], file: bytes) -> str:
async def upload_module_file(self, module_file_info: ModuleFileInfo, file: bytes) -> str:
"""Upload a module file

::
Expand All @@ -2400,7 +2400,7 @@ async def upload_module_file(self, module_file_info: Optional[ModuleFileInfo], f
)

Args:
module_file_info (Optional[viam.proto.app.ModuleFileInfo]): Relevant metadata.
module_file_info (viam.proto.app.ModuleFileInfo): Relevant metadata.
file (bytes): Bytes of file to upload.

Returns:
Expand Down
Loading