Open
Conversation
* tbody, thead, tfoot - revise role to indicate they are either `rowgroup` or have no corresponding role depending on role of ancestor table element. Update allowed roles to be either ‘none’ if ancestor table is exposed as a table, grid or treegrid. If not one of those 3 roles, then any role is allowed. * update tr to note that it is exposed as a row if ancestor table is exposed as a table, grid or treegrid. otherwise on corresponding role. * update th and td role columns to be consistent. remove link to HTML AAM in th - it wasn’t in the td one, and we already indicate that implicit semantics are defined in HTML AAM in other areas of the spec. indicate that th/td have no corresponding role if the ancestor table is not exposed as a table, grid or treegrid
just making some changes to the file to try and mitigate the the Travis build process getting all mucked up again.
scottaohara
added
the
Do not merge
Member
Author
|
need to wait on merging this one. |
stevefaulkner
approved these changes
Jan 17, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #258 by revising allowed roles on
tbody,tfoot,theadwhen they are children of an ancestortableexposed as having a role oftable,gridortreegrid.This PR also updates the following:
trto note that it is exposed as arowif ancestortableis exposed as atable,gridortreegrid. otherwise on corresponding role.thandtdrole columns to be consistent. remove link to HTML AAM inth- it wasn’t in thetdone, and we already indicate that implicit semantics are defined in HTML AAM in other areas of the spec. indicate thatth/tdhave no corresponding role if the ancestortableis not exposed as atable,gridortreegridFurther updates can likely be made to the allowed roles on these elements, as I indicated in my comments within #258. But I think those decisions can be made later.
Preview | Diff