Add organism classification service (taxonomy-priority) with diagnostics and tests#2380
Closed
SatoryKono wants to merge 1 commit intomainfrom
Closed
Add organism classification service (taxonomy-priority) with diagnostics and tests#2380SatoryKono wants to merge 1 commit intomainfrom
SatoryKono wants to merge 1 commit intomainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
assay_taxonomy_idandassay_organisminputs.assay_organismandassay_taxonomy_iddisagree.Description
classify_organism(assay_organism, assay_taxonomy_id) -> OrganismClassificationResultwith theOrganismClassenum andOrganismClassificationResultdataclass to captureorganism_class,normalized_organism,taxonomy_id,source,source_conflictandreason(file:src/bioetl/domain/services/organism_classification_service.py).hiv,eel,rice,monkey) and lightweight heuristic hints plus lookup tables for known taxonomy IDs and canonical names.source_conflict=Trueand populatereason; unmapped-but-valid taxonomy IDs returnsource="unresolved"with explanation.tests/unit/domain/services/test_organism_classification_service.py).src/bioetl/domain/services/__init__.py,src/bioetl/infrastructure/config/*,src/bioetl/infrastructure/system/memory_monitor.py,src/bioetl/__init__.py, and one test formatting change).Testing
uv run python -m pytest tests/unit/domain/services/test_organism_classification_service.py -qand they passed. ✅uv run python -m pytest tests/architecture/test_code_formatting.py tests/architecture/test_code_metrics.py -qand both passed after formatting fixes. ✅uv run python -m mypy --strict src/bioetl/completed with no errors. ✅uv run python -m pytest tests/ -x -q; the run failed on an unrelated live e2e test due to an upstream ChEMBL API500 Internal Server Error(tests/e2e/test_full_pipeline.py::TestChEMBLPipelineE2E::test_chembl_activity_full_run), which is external to the classification logic and not caused by this change.Codex Task