fix: add missing autodie throws for link ELOOP and rename ENOTEMPTY#285
Draft
Koan-Bot wants to merge 1 commit intocpanel:masterfrom
Draft
fix: add missing autodie throws for link ELOOP and rename ENOTEMPTY#285Koan-Bot wants to merge 1 commit intocpanel:masterfrom
Koan-Bot wants to merge 1 commit intocpanel:masterfrom
Conversation
…MPTY __link's CIRCULAR_SYMLINK error path and __rename's ENOTEMPTY error path both set $! but skipped _throw_autodie(), breaking autodie compatibility. Also removes dead $set_error variable in __chown (declared but never set). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Quality Gate WarningTests failed: FAILED Auto-merge was skipped due to quality gate issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_throw_autodie()calls on two error paths in CORE overrides.__link(circular symlink → ELOOP) and__rename(non-empty target dir → ENOTEMPTY) both set$!but never called_throw_autodie(), silently breaking autodie compatibility. Every other error path in both functions already has this call._throw_autodie('func', @_) if _caller_has_autodie_for('func')pattern. Also removed dead$set_errorvariable in__chown(declared but never set to true — no behavioral change).Test plan
use autodie; link(circular_symlink, target)now throwsuse autodie; rename(dir, non_empty_dir)now throws🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 5 insertions(+), 10 deletions(-)
Code scan: clean
Tests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline