Skip to content

fix: add missing autodie throws for link ELOOP and rename ENOTEMPTY #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Koan-Bot wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: add missing autodie throws for link ELOOP and rename ENOTEMPTY #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions lib/Test/MockFile.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3410,6 +3410,7 @@ sub __link ($$) {
}
if ( $target_path eq CIRCULAR_SYMLINK ) {
$! = ELOOP;
_throw_autodie( 'link', @_ ) if _caller_has_autodie_for('link');
return 0;
}
$source_mock = $files_being_mocked{$target_path};
Expand Down Expand Up @@ -3626,6 +3627,7 @@ sub __rename ($$) {
if ( $mock_old->is_dir && $mock_new->exists && $mock_new->is_dir ) {
if ( grep { $_->exists } _files_in_dir( $mock_new->{'path'} ) ) {
$! = ENOTEMPTY;
_throw_autodie( 'rename', @_ ) if _caller_has_autodie_for('rename');
return 0;
}
}
Expand Down Expand Up @@ -3746,7 +3748,6 @@ sub __chown (@) {
}
}

my $set_error;
my $num_changed = 0;
foreach my $file (@files) {
my $mock = $mocked_files{$file};
Expand All @@ -3761,23 +3762,17 @@ sub __chown (@) {

# Handle broken/circular symlink errors
if ( ref $mock eq 'A::BROKEN::SYMLINK' ) {
$set_error
or $! = ENOENT;
$! = ENOENT;
next;
}
if ( ref $mock eq 'A::CIRCULAR::SYMLINK' ) {
$set_error
or $! = ELOOP;
$! = ELOOP;
next;
}

# Even if you're root, nonexistent file is nonexistent
if ( !$mock->exists() ) {

# Only set the error once
$set_error
or $! = ENOENT;

$! = ENOENT;
next;
}

Expand Down
Loading