fix: lance error TooMuchWriteContention should be converted to a retryable namespace error.

[wojiaodoubao]

In semantics, I think TooMuchWriteContention should be converted to NamespaceError::Throttled. Because TooMuchWriteContention is caused by RetryableCommitConflict, which means too many concurrent commits and can be retried, just like CommitConflict.

Currently, TooMuchWriteContention and IncompatibleTransaction are both converted into NamespaceError::ConcurrentModification. Since RetryableCommitConflict should be retry and IncompatibleTransaction should not, the caller can't distinguish whether the ConcurrentModification error should be retried

[github-actions]

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

[github-actions]

Review

The semantic fix is correct: TooMuchWriteContention originates from RetryableCommitConflict with exhausted retries, so mapping it to Throttled (retryable) instead of ConcurrentModification (non-retryable) is the right call. This lets callers distinguish between errors they can retry vs. errors they cannot.

One minor issue:

The doc comment on convert_lance_commit_error (line 270) still says:

/// - `TooMuchWriteContention`: RetryableCommitConflict (semantic conflict) retries exhausted -> ConcurrentModification

This should be updated to reflect the new mapping (-> Throttled), and ideally moved next to the CommitConflict bullet since they now share the same branch.

Otherwise LGTM.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
rust/lance-namespace-impls/src/dir/manifest.rs	0.00%	4 Missing ⚠️

📢 Thoughts on this report? Let us know!