Skip to content

fix: lance error TooMuchWriteContention should be converted to a retryable namespace error. #6177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wojiaodoubao wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: lance error TooMuchWriteContention should be converted to a retryable namespace error. #6177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions rust/lance-namespace-impls/src/dir/manifest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,13 +274,15 @@ impl std::fmt::Debug for ManifestNamespace {
fn convert_lance_commit_error(e: &LanceError, operation: &str, object_id: Option<&str>) -> Error {
match e {
// CommitConflict: version collision retries exhausted -> Throttled (safe to retry)
LanceError::CommitConflict { .. } => NamespaceError::Throttled {
message: format!("Too many concurrent writes, please retry later: {:?}", e),
// TooMuchWriteContention: RetryableCommitConflict (semantic conflict) retries exhausted -> Throttled (safe to retry)
LanceError::CommitConflict { .. } | LanceError::TooMuchWriteContention { .. } => {
NamespaceError::Throttled {
message: format!("Too many concurrent writes, please retry later: {:?}", e),
}
.into()
}
.into(),
// TooMuchWriteContention: RetryableCommitConflict (semantic conflict) retries exhausted -> ConcurrentModification
// IncompatibleTransaction: incompatible concurrent change -> ConcurrentModification
LanceError::TooMuchWriteContention { .. } | LanceError::IncompatibleTransaction { .. } => {
LanceError::IncompatibleTransaction { .. } => {
let message = if let Some(id) = object_id {
format!(
"Object '{}' was concurrently modified by another operation: {:?}",
Expand Down
Loading