Rollup of 4 pull requests#153576
Conversation
All of the existing call sites are directly touching `tcx.dep_graph` anyway, so the extra layer of indirection provides no real benefit.
Currently we use a mix of `C::Key` and `&C::Key` parameters. The former is more common and a bit nicer, so convert some of the latter. This results in less converting between the two types, and fewer sigils.
Use `&C::Key` less in queries. Currently we use a mix of `C::Key` and `&C::Key` parameters. The former is more common and a bit nicer, so convert some of the latter. This results in less converting between the two types, and fewer sigils.
Remove the `rustc_data_structures::assert_matches!` re-exports - rust-lang#151359 - rust-lang#153462 --- Now that the bootstrap stage0 compiler has been bumped to 1.95, we can remove these temporary re-exports from `rustc_data_structures`, and once again import the `assert_matches!` macros directly from std.
…cote Replace the `try_mark_green` hook with direct calls to `tcx.dep_graph` All of the existing call sites are directly touching `tcx.dep_graph` anyway, so the extra layer of indirection provides no real benefit. There should be no change to compiler behaviour. r? nnethercote (or compiler)
rendering interpreter OOM as OOM instead of ICE Fixes rust-lang#149643. Alternative to rust-lang#153481.
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: c7b206bba4 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c7b206b (parent) -> b41f22d (this PR) Test differencesShow 122 test diffs122 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard b41f22de2a13a0babd28771e96feef4c309f54aa --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (b41f22d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.3%, secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.2%, secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 488.157s -> 478.517s (-1.97%) |
Successful merges:
&C::Keyless in queries. #153464 (Use&C::Keyless in queries.)rustc_data_structures::assert_matches!re-exports #153553 (Remove therustc_data_structures::assert_matches!re-exports)try_mark_greenhook with direct calls totcx.dep_graph#153561 (Replace thetry_mark_greenhook with direct calls totcx.dep_graph)r? @ghost
Create a similar rollup