perf(store): remove dead sortedStore field from VersionIndexedStore#2849
Merged
perf(store): remove dead sortedStore field from VersionIndexedStore#2849
sortedStore field from VersionIndexedStore#2849Conversation
The sortedStore *dbm.MemDB field in VersionIndexedStore was allocated in the constructor (NewVersionIndexedStore) but never read or written anywhere in the codebase. Each VIS instance allocated a full MemDB with btree + FreeList — ~21 VIS per transaction × ~200K txs in 30s = ~4.2M dead MemDB allocations. Remove the field and its allocation entirely. Results (M4 Max benchmark, diff vs previous): - NewMemDB via VIS: 14.9 GB → 13.5 MB (eliminated) - btree.NewFreeListG: 15.3 GB → ~4.3 GB (-11 GB) - memclrNoHeapPointers CPU: 10.71s → 5.45s (-49%) - TPS: 7,200-8,600 → 8,400-9,400 (median ~8,000 → ~9,000) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
This was referenced Feb 11, 2026
pdrobnjak
changed the title
sortedStore field from VersionIndexedStore
stevenlanders
approved these changes
Feb 11, 2026
arajasek
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove unused
sortedStorefield and its allocation fromVersionIndexedStore.